-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download artifacts to relative locations inside the task directory #944
Conversation
bd6dcb5
to
a55b4fc
Compare
if err != nil { | ||
return nil, err | ||
} | ||
path = rel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defense in depth, I would re-verify that taskDir is a parent of absPath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing the check here is unnecessary as if the path has escaped, it will be invalid inside the chroot.
Minor comments, LGTM |
Download artifacts to relative locations inside the task directory
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR: